From: Florian Müllner <fmuellner@gnome.org>
Date: Tue, 25 Feb 2020 17:15:49 +0000 (+0100)
Subject: loginDialog: Do not expand "Not listed" button
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~772^2^2~35
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=19fc7c4d31df94d223302187c1de118d42a2be7f;p=gnome-shell.git

loginDialog: Do not expand "Not listed" button

Visually the button is just an interactive label, so having the
interactive area extend to the empty space next to the label
is surprising.

Instead, left-align the whole button rather than just the label
inside, so the clickable area corresponds to the visible one.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/1046
---

diff --git a/js/gdm/loginDialog.js b/js/gdm/loginDialog.js
index b3a95b838..b60d971a2 100644
--- a/js/gdm/loginDialog.js
+++ b/js/gdm/loginDialog.js
@@ -456,7 +456,6 @@ var LoginDialog = GObject.registerClass({
         let notListedLabel = new St.Label({
             text: _("Not listed?"),
             style_class: 'login-dialog-not-listed-label',
-            x_align: Clutter.ActorAlign.START,
         });
         this._notListedButton = new St.Button({
             style_class: 'login-dialog-not-listed-button',
@@ -464,6 +463,7 @@ var LoginDialog = GObject.registerClass({
             can_focus: true,
             child: notListedLabel,
             reactive: true,
+            x_align: Clutter.ActorAlign.START,
         });
 
         this._notListedButton.connect('clicked', this._hideUserListAskForUsernameAndBeginVerification.bind(this));